fix(hero): centre the home hero crystal so it spins in place - #60
Merged
Conversation
The auto-rotating hero crystal's geometry was never centred on its
centroid, so it orbited the group origin and drifted off-centre in
its specimen plate at some rotation angles (often off centre). Added
geometry.center() + computeBoundingSphere() (matching the working
Crystal3DViewer) and removed the compensating hardcoded
<Center position={[0,0.15,0]}> offset.
Browser-verified: crystal stays centred across a full rotation,
reduced-motion static+centred, both themes + mobile OK, no console
errors. Build clean.
Deploying gemmology-dev with
|
| Latest commit: |
f55c631
|
| Status: | 🚫 Build failed. |
|
🚀 Preview deployed to: https://d282692c.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geometry.center()+computeBoundingSphere()(matching the workingCrystal3DViewer) and removed the compensating hardcoded<Center position={[0,0.15,0]}>offset.Test plan